fix(mobile): show project favicons in filters - #7984
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Skipped Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically. |
Closes #7981
UI Changes
What Changed
The Android project filter now renders each project's resolved favicon on the right in the custom Android menu.
All projectskeeps its folder icon, and the selected check remains visible.This applies to the Home header and persistent sidebar filter. iOS keeps using the native menu unchanged.
Why
T3 already resolves and displays these icons elsewhere, but Android's project filter only showed labels. That made projects harder to distinguish at a glance and inconsistent with desktop.
Test plan
Checklist
GPT-5 in Codex Desktop.
Note
Low Risk
Android-only UI in the custom anchored menu; iOS native menus are unchanged and filter action IDs stay the same.
Overview
Android project filter menus now show resolved project favicons next to each row, with a folder icon for All projects, while keeping the selected checkmark.
AndroidAnchoredMenu/ControlPillMenugain an optionalrenderActionTrailingslot (ignored on iOS). Home header and the persistent sidebar passAndroidProjectFilterIcon, and project filter options now includeenvironmentId,workspaceRoot, andfaviconPathso those icons can load.Reviewed by Cursor Bugbot for commit 9fddde9. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Show project favicons in Android filter menus
renderActionTrailingprop toAndroidAnchoredMenuandControlPillMenu, allowing custom trailing content per menu action on Android (no effect on iOS)AndroidProjectFilterIconwhich renders a folder icon for the 'All projects' action and aProjectFaviconfor specific project actionsHomeListFilterMenuProjectwithenvironmentId,workspaceRoot, andfaviconPathfields so project data is available to the icon rendererbuildAndroidProjectFilterActionsandresolveAndroidProjectFilterProjectutils to construct project menu actions with stable ids and resolve the matching project for icon renderingMacroscope summarized 9fddde9.